Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(PC-31863)[PRO] fix: stop displaying EAN search when draft offer is created but not product based #14179

Merged
merged 1 commit into from
Sep 20, 2024
Merged

(PC-31863)[PRO] fix: stop displaying EAN search when draft offer is created but not product based #14179

merged 1 commit into from
Sep 20, 2024

Conversation

asaez-pass
Copy link
Contributor

@asaez-pass asaez-pass commented Sep 17, 2024 •
edited
Loading

But de la pull request

Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-31863

Objectifs :

  • Lorsque l'on crée une offre individuelle, si on passe de "Détails" à "Informations" en cliquant sur "Enregistrer & continuer", alors l'offre devient une draft offer (une requête POST est effectuée).
  • En revenant sur "Détails", on se base sur les valeurs de l'objet draft offer ainsi créé.
  • Si ce draft offer n'est pas basé sur un produit, alors on considère que la recherche EAN ne doit plus être disponible.

Vérifications

  • J'ai écrit les tests nécessaires
  • J'ai mis à jour le fichier des plans de tests du portail pro si nécessaire
  • J'ai mis à jour la liste des routes et des titres de pages du portail pro si j'en ai rajouté/modifié ou supprimé une.
  • J'ai relu attentivement les migrations, en particulier pour éviter les locks, et je préviens les équipes Shérif et Data
  • J'ai ajouté des screenshots pour d'éventuels changements graphiques

@asaez-pass asaez-pass force-pushed the PC-31863-stop-displayin-ean-search-draft-offer-non-product branch from f29c8d7 to 9dfd839 Compare September 17, 2024 08:33
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 17, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit dc15363):

https://pc-pro-testing--pr14179-pc-31863-stop-displa-ct2qgxxf.web.app

(expires Sun, 22 Sep 2024 14:03:10 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 032d233ee67e1c50d6af12e29c936c7076770eb1

@asaez-pass asaez-pass force-pushed the PC-31863-stop-displayin-ean-search-draft-offer-non-product branch from 9dfd839 to 66f393a Compare September 17, 2024 12:21
@asaez-pass asaez-pass force-pushed the PC-31828-disable-or-redirect-submit-on-callout branch from f6a208b to 521110d Compare September 19, 2024 09:02
@asaez-pass asaez-pass force-pushed the PC-31863-stop-displayin-ean-search-draft-offer-non-product branch from 66f393a to 7584056 Compare September 19, 2024 09:04
Base automatically changed from PC-31828-disable-or-redirect-submit-on-callout to master September 20, 2024 08:05
@asaez-pass asaez-pass force-pushed the PC-31863-stop-displayin-ean-search-draft-offer-non-product branch from 7584056 to dc15363 Compare September 20, 2024 13:52
@asaez-pass asaez-pass merged commit 82c75b3 into master Sep 20, 2024
19 checks passed
@asaez-pass asaez-pass deleted the PC-31863-stop-displayin-ean-search-draft-offer-non-product branch September 20, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmeigniez-pass gmeigniez-pass gmeigniez-pass approved these changes

@abouabdallaoui-pass abouabdallaoui-pass abouabdallaoui-pass approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asaez-pass @abouabdallaoui-pass @gmeigniez-pass